Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legend for plotlist with multiple plots #4546

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

asinghvi17
Copy link
Member

Description

PlotLists with multiple subsidiary plots weren't getting decomposed to their individual plots in get_plots, this fixes that.

Fixes SciML/SciMLBase.jl#833

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added unit tests for new algorithms, conversion methods, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Oct 30, 2024

Benchmark Results

SHA: 9f49ada97e8ccbc8bd38dc780cd58d20142cc52b

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@SimonDanisch SimonDanisch merged commit 379bb69 into master Oct 31, 2024
22 checks passed
@SimonDanisch SimonDanisch deleted the as/legend_for_plotlist branch October 31, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Automatic legend generation for solution plots not working with Makie
3 participants