Resolve :data space when deciding whether to connect transformations

[ffreyer]

Description

Fixes #4722

We have a check which stops transformations from connecting if parent.space != child.space. If the parent is a scene this check looks at the camera and treats campixel! as pixel space. This pr adjusts the check to trace back to the scene if space == :data, as that could still be pixel space.

In #4722 the text shown in legend is a text plot to a pixel space scene. The linesegments used for LaTeXStrings are hard-coded to be in pixel space. Other elements of the plot are in space == :data, which causes transformation to not be connected and thus translations to not propagate to the linesegments.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist

• Added an entry in CHANGELOG.md (for new features and breaking changes)
• Added or changed relevant sections in the documentation
• Added unit tests for new algorithms, conversion methods, etc.
• Added reference image tests for new plotting functions, recipes, visual options, etc.

[MakieBot]

Benchmark Results

SHA: 9f9d77e8578d68b7bf74dfb17d2ebfa98530b504

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.