Merge pull request #34 from MasonM/fix-request-headers-constraint-sid…

…e-effecs Fix side effects in RequestHeadersConstraint
Maks3w · Jun 13, 2017 · a41ec65 · a41ec65
2 parents 3e56d78 + 1cac40b
commit a41ec65
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/PhpUnit/RequestHeadersConstraint.php b/src/PhpUnit/RequestHeadersConstraint.php
@@ -24,6 +24,8 @@ public function __construct($headersParameters, Validator $validator)
                 // @codeCoverageIgnoreEnd
             }
 
+            $headerParameter = clone $headerParameter;
+
             $normalizedName = strtolower($headerParameter->name);
             unset($headerParameter->name);
 

diff --git a/tests/PhpUnit/RequestHeadersConstraintTest.php b/tests/PhpUnit/RequestHeadersConstraintTest.php
@@ -17,11 +17,11 @@ class RequestHeadersConstraintTest extends TestCase
      * @var Constraint
      */
     protected $constraint;
+    const TEST_SCHEMA = '[{"name":"X-Required-Header","in":"header","description":"Required header","required":true,"type":"string"},{"name":"X-Optional-Header","in":"header","description":"Optional header","type":"string"}]';
 
     protected function setUp()
     {
-        $schema = '[{"name":"X-Required-Header","in":"header","description":"Required header","required":true,"type":"string"},{"name":"X-Optional-Header","in":"header","description":"Optional header","type":"string"}]';
-        $schema = json_decode($schema);
+        $schema = json_decode(self::TEST_SCHEMA);
 
         $this->constraint = new RequestHeadersConstraint($schema, new Validator());
     }
@@ -73,4 +73,13 @@ public function testInvalidHeaderType()
             );
         }
     }
+
+    public function testSchemaUnchanged()
+    {
+        $schema = json_decode(self::TEST_SCHEMA);
+        new RequestHeadersConstraint($schema, new Validator());
+
+        // Make sure there were no side effects ($schema should be unchanged)
+        self::assertEquals($schema, json_decode(self::TEST_SCHEMA));
+    }
 }