address linters

cmd/deposit.go

@@ -13,7 +13,7 @@ var depositCmd = &cobra.Command{
 	Long: `Deposit the minimum needed deposit for a given governance proposal.
 If no proposal ID is given by the user, the latest proposal is queried and deposited for.`,
 	Args: cobra.RangeArgs(0, 1),
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		bin, err := utils.NewEvmosTestingBinary()
 		if err != nil {
 			bin.Logger.Error().Msgf("error creating binary: %v", err)

cmd/upgrade.go

@@ -16,7 +16,7 @@ var upgradeCmd = &cobra.Command{
 	Long: `Prepare an upgrade of a node by submitting a governance proposal, 
 voting for it using all keys of in the keyring and having it pass.`,
 	Args: cobra.ExactArgs(1),
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		bin, err := utils.NewEvmosTestingBinary()
 		if err != nil {
 			bin.Logger.Error().Msgf("error creating binary: %v", err)

cmd/vote.go

@@ -13,7 +13,7 @@ var voteCmd = &cobra.Command{
 	Long: `Vote for a governance proposal with all keys in the keyring.
 If no proposal ID is passed, the latest proposal on chain is queried and used.`,
 	Args: cobra.RangeArgs(0, 1),
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		bin, err := utils.NewEvmosTestingBinary()
 		if err != nil {
 			bin.Logger.Error().Msgf("error creating binary: %v", err)

gov/deposit_test.go

@@ -32,7 +32,6 @@ func TestParseMinDepositFromResponse(t *testing.T) {
 	}
 
 	for _, tc := range testcases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

gov/proposal.go

@@ -44,7 +44,7 @@ func GetProposalIDFromSubmitEvents(events []sdk.StringEvent) (int, error) {
 		}
 	}
 
-	return 0, fmt.Errorf("proposal submission event not found")
+	return 0, errors.New("proposal submission event not found")
 }
 
 // QueryLatestProposalID queries the latest proposal ID.
@@ -103,7 +103,7 @@ func SubmitUpgradeProposal(bin *utils.Binary, targetVersion string, upgradeHeigh
 	}
 
 	if len(events) == 0 {
-		return 0, fmt.Errorf("no events found in transaction to submit proposal")
+		return 0, errors.New("no events found in transaction to submit proposal")
 	}
 
 	return GetProposalIDFromSubmitEvents(events)

gov/proposal_test.go

@@ -77,9 +77,9 @@ func TestGetProposalID(t *testing.T) {
 	}
 
 	for _, tc := range testcases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
+
 			propID, err := gov.GetProposalIDFromSubmitEvents(tc.events)
 			if tc.expError {
 				require.Error(t, err, "expected error parsing proposal ID")

utils/binary.go

@@ -33,7 +33,7 @@ type Binary struct {
 func NewBinary(home, appd string, logger zerolog.Logger) (*Binary, error) {
 	// check if home directory exists
 	if _, err := os.Stat(home); os.IsNotExist(err) {
-		return nil, errors.Wrap(err, fmt.Sprintf("home directory does not exist: %s", home))
+		return nil, errors.Wrap(err, "home directory does not exist: "+home)
 	}
 
 	// check if binary is installed

utils/delegations_test.go

@@ -35,9 +35,9 @@ func TestParseDelegationsFromResponse(t *testing.T) {
 	}
 
 	for _, tc := range testcases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
+
 			delegations, err := utils.ParseDelegationsFromResponse(cdc, tc.out)
 			if tc.expError {
 				require.Error(t, err, "expected error parsing delegations")
@@ -49,6 +49,7 @@ func TestParseDelegationsFromResponse(t *testing.T) {
 				for _, delegation := range delegations {
 					vals = append(vals, delegation.ValidatorAddress)
 				}
+
 				require.Equal(t, tc.expVals, vals, "expected different validators")
 			}
 		})

utils/keys.go

@@ -2,6 +2,7 @@ package utils
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 
 	cryptokeyring "github.com/cosmos/cosmos-sdk/crypto/keyring"
@@ -42,7 +43,7 @@ func FilterAccountsWithDelegations(bin *Binary) ([]Account, error) {
 	var stakingAccs []Account
 
 	if len(bin.Accounts) == 0 {
-		return nil, fmt.Errorf("no accounts found")
+		return nil, errors.New("no accounts found")
 	}
 
 	for _, acc := range bin.Accounts {

utils/keys_test.go

@@ -32,9 +32,9 @@ func TestParseKeysFromOut(t *testing.T) {
 	}
 
 	for _, tc := range testcases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
+
 			accounts, err := utils.ParseAccountsFromOut(tc.out)
 			if tc.expError {
 				require.Error(t, err, "expected error parsing accounts")
@@ -46,6 +46,7 @@ func TestParseKeysFromOut(t *testing.T) {
 				for _, account := range accounts {
 					keys = append(keys, account.Name)
 				}
+
 				require.Equal(t, tc.expKeys, keys, "expected different keys")
 			}
 		})

utils/utils.go

@@ -110,7 +110,7 @@ func GetTxEvents(bin *Binary, out string) ([]sdk.StringEvent, error) {
 		nAttempts = 10
 	)
 
-	for i := 0; i < nAttempts; i++ {
+	for range nAttempts {
 		txOut, err = ExecuteBinaryCmd(bin, BinaryCmdArgs{
 			Subcommand: []string{"q", "tx", txHash, "--output=json"},
 			Quiet:      true,

utils/utils_test.go

@@ -43,9 +43,9 @@ func TestGetTxHashFromResponse(t *testing.T) {
 	}
 
 	for _, tc := range testcases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
+
 			hash, err := utils.GetTxHashFromTxResponse(cdc, tc.out)
 			if tc.expError {
 				require.Error(t, err, "expected error getting tx hash")
@@ -92,9 +92,9 @@ func TestGetEventsFromTxResponse(t *testing.T) {
 	}
 
 	for _, tc := range testcases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
+
 			events, err := utils.GetEventsFromTxResponse(cdc, tc.out)
 			if tc.expError {
 				require.Error(t, err, "expected error getting tx events")