Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement Map ItemReader #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/floe.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
require_relative "floe/workflow/choice_rule/data"
require_relative "floe/workflow/context"
require_relative "floe/workflow/item_processor"
require_relative "floe/workflow/item_reader"
require_relative "floe/workflow/intrinsic_function"
require_relative "floe/workflow/intrinsic_function/parser"
require_relative "floe/workflow/intrinsic_function/transformer"
Expand Down
24 changes: 24 additions & 0 deletions lib/floe/workflow/item_reader.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# frozen_string_literal: true

module Floe
class Workflow
class ItemReader
include ValidationMixin

attr_reader :name, :resource, :parameters, :reader_config, :max_items, :runner

def initialize(payload, name)
@name = name
@resource = payload["Resource"]
@parameters = PayloadTemplate.new(payload["Parameters"]) if payload["Parameters"]
@reader_config = payload["ReaderConfig"] || {}
@max_items = reader_config["MaxItems"]

missing_field_error!("Resource") unless @resource.kind_of?(String)
invalid_field_error!("ReaderConfig.MaxItems", @max_items, "must be positive") if @max_items && @max_items < 0

@runner = wrap_parser_error("Resource", @resource) { Floe::Runner.for_resource(@resource) }
end
end
end
end
2 changes: 1 addition & 1 deletion lib/floe/workflow/states/map.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def initialize(workflow, name, payload)
@catch = payload["Catch"].to_a.map { |catcher| Catcher.new(catcher) }
@item_processor = ItemProcessor.new(payload["ItemProcessor"], name)
@items_path = ReferencePath.new(payload.fetch("ItemsPath", "$"))
@item_reader = payload["ItemReader"]
@item_reader = ItemReader.new(payload["ItemReader"], name + ["ItemReader"]) if payload["ItemReader"]
@item_selector = payload["ItemSelector"]
@item_batcher = payload["ItemBatcher"]
@result_writer = payload["ResultWriter"]
Expand Down
27 changes: 27 additions & 0 deletions spec/workflow/item_reader_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
RSpec.describe Floe::Workflow::ItemReader do
let(:subject) { described_class.new(payload, ["Map", "ItemReader"]) }

describe "#initialize" do
let(:payload) { {"Resource" => "docker://item_reader:latest"} }

it "returns an ItemReader instance" do
expect(subject).to be_kind_of(described_class)
end

context "Missing a \"Resource\" field" do
let(:payload) { {} }

it "raises an exception" do
expect { subject }.to raise_error(Floe::InvalidWorkflowError, "Map.ItemReader does not have required field \"Resource\"")
end
end

context "with an invalid ReaderConfig" do
let(:payload) { {"Resource" => "docker://item_reader:latest", "ReaderConfig" => {"MaxItems" => -1}} }

it "raises an exception" do
expect { subject }.to raise_error(Floe::InvalidWorkflowError, "Map.ItemReader field \"ReaderConfig.MaxItems\" value \"-1\" must be positive")
end
end
end
end