Skip to content

[WIP] Skip writing session for all API GET requests #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Skip writing session for all API GET requests #1292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/controllers/api/base_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
module Api
class BaseController < ActionController::API
after_action :skip_session_write

def skip_session_write
request.session_options[:skip] = true if %w[GET HEAD OPTIONS].include?(request.request_method)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In discussion, Jason thinks we might not need to gate this for GET as all requests should be able to bypass writing session. 🙏 ❤️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure some pages using react work after trying to bypass session writes for all request... also make sure API requests outside of the UI still work when reusing a token.

end

TAG_NAMESPACE = "/managed".freeze

#
Expand Down