Automate - Refactoring infra vm check_pre_retirement method. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tinaafitz |
mkanoor
reviewed
Jan 26, 2017
| let(:ae_result) { "retry" } | ||
| it_behaves_like "#vm power state" | ||
| end | ||
| context "unknown" do |
There was a problem hiding this comment.
@billfitzgerald0120
please add a empty line between contexts
billfitzgerald0120
force-pushed
the
refactor_i_check_pre_retirement
branch
2 times, most recently
from
7fa692e to
2ad78d4
Compare
billfitzgerald0120
force-pushed
the
refactor_i_check_pre_retirement
branch
from
2ad78d4 to
4658215
Compare
|
Checked commit billfitzgerald0120@4658215 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
mkanoor
approved these changes
Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the check_pre_retirement method for the infrastructure Vm. This PR is based on the issue bellow.
Links [Optional]
ManageIQ/manageiq#12038