Refactor Quota Source method and spec #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3719
💛 - Coveralls |
tinaafitz
suggested changes
Oct 8, 2019
content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/quota_source.rb
Show resolved
Hide resolved
content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/quota_source.rb
Outdated
Show resolved
Hide resolved
gmcculloug
reviewed
Oct 8, 2019
content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/quota_source.rb
Outdated
Show resolved
Hide resolved
GregP
force-pushed
the
refactor_quota_source
branch
2 times, most recently
from
1141ad3 to
2bab1d2
Compare
gmcculloug
reviewed
Oct 15, 2019
| @handle = handle | ||
| end | ||
|
|
||
| def miq_request |
There was a problem hiding this comment.
@GregP This method belongs in the private method section.
GregP
force-pushed
the
refactor_quota_source
branch
from
2bab1d2 to
cf13086
Compare
|
Checked commit GregP@cf13086 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
gmcculloug
approved these changes
Oct 15, 2019
tinaafitz
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the issue below:
ManageIQ/manageiq#12038
@miq-bot add_label refactoring