Refactor redhat_customizerequest method for VM Provisioning. #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkomanek
force-pushed
the
redhat_customizerequest_refactoring
branch
from
2298d7f to
37cb159
Compare
Pull Request Test Coverage Report for Build 4327
💛 - Coveralls |
pkomanek
force-pushed
the
redhat_customizerequest_refactoring
branch
5 times, most recently
from
e975b35 to
b40a519
Compare
pkomanek
force-pushed
the
redhat_customizerequest_refactoring
branch
2 times, most recently
from
b740e40 to
a9508a5
Compare
pkomanek
changed the title
lfu
reviewed
Feb 18, 2020
| log(:info, "Inspecting prov.eligible_windows_images: #{prov.eligible_windows_images.inspect}") | ||
| pxe_image = prov.eligible_windows_images.detect { |pi| pi.name.casecmp(template.name) == 0 } | ||
| if pxe_image.nil? | ||
| update_and_raise("Failed to find matching PXE Image") |
There was a problem hiding this comment.
The behavior before is to log in the file, update the object then raise an error.
Seems logging in the file is skipped here. Is it by intention?
pkomanek
force-pushed
the
redhat_customizerequest_refactoring
branch
from
a9508a5 to
a8547b2
Compare
|
Some comments on commits pkomanek/manageiq-content@0c5f6f3~...a8547b2 spec/content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/redhat_customizerequest_spec.rb
|
|
Checked commits pkomanek/manageiq-content@0c5f6f3~...a8547b2 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/redhat_customizerequest.rb
|
lfu
approved these changes
Mar 5, 2020
tinaafitz
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method refactoring and creating tests.
This PR is based on the issue below.
ManageIQ/manageiq#12038
@miq-bot add_label refactoring
@miq-bot assign @tinaafitz