Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor vmware_customizerequest method for VM Provisioning. #638

Merged

Conversation

pkomanek
Copy link
Contributor

Method refactoring and creating tests.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

@coveralls
Copy link

coveralls commented Feb 17, 2020

Pull Request Test Coverage Report for Build 4261

  • 94 of 94 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 97.532%

Totals Coverage Status
Change from base Build 4224: 0.07%
Covered Lines: 3201
Relevant Lines: 3282

💛 - Coveralls

@pkomanek pkomanek force-pushed the vmware_customizerequest_method_refactoring branch from 882579e to 461ab89 Compare February 17, 2020 14:46
@miq-bot
Copy link
Member

miq-bot commented Feb 17, 2020

Some comments on commits pkomanek/manageiq-content@7a5407a~...461ab89

content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/vmware_customizerequest.rb

  • 💣 💥 🔥 🚒 - 33 - Detected cfme
  • 💣 💥 🔥 🚒 - 49 - Detected cfme

spec/content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/vmware_customizerequest_spec.rb

  • ⚠️ - 171 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Feb 17, 2020

Checked commits pkomanek/manageiq-content@7a5407a~...461ab89 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint
2 files checked, 1 offense detected

content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/vmware_customizerequest.rb

@pkomanek pkomanek changed the title [WIP]Refactor vmware_customizerequest method for VM Provisioning. Refactor vmware_customizerequest method for VM Provisioning. Mar 12, 2020
@miq-bot miq-bot removed the wip label Mar 12, 2020
@tinaafitz tinaafitz merged commit b8939fa into ManageIQ:master Mar 24, 2020
@pkomanek pkomanek deleted the vmware_customizerequest_method_refactoring branch March 24, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants