Refactor redhat_preprovision method for VM Provisioning. #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4414
💛 - Coveralls |
pkomanek
force-pushed
the
redhat_preprovision_method_refactoring
branch
from
1133c16 to
3aca2f2
Compare
pkomanek
changed the title
pkomanek
changed the title
pkomanek
changed the title
lfu
reviewed
Mar 24, 2020
Comment on lines
31
to
33
| res = "Owner: #{prov_opt[:owner_first_name]} #{prov_opt[:owner_last_name]}\n"\ | ||
| "Email: #{prov_opt[:owner_email]}\n"\ | ||
| "Source Template: #{template.name}" |
There was a problem hiding this comment.
res = %Q(
Owner: #{prov_opt[:owner_first_name]} #{prov_opt[:owner_last_name]}
Email: #{prov_opt[:owner_email]}
Source Template: #{template.name}
)
|
It looks good except minor change. |
pkomanek
force-pushed
the
redhat_preprovision_method_refactoring
branch
from
3aca2f2 to
ef39009
Compare
|
Please use |
pkomanek
force-pushed
the
redhat_preprovision_method_refactoring
branch
from
ef39009 to
3f5aadb
Compare
|
Checked commits pkomanek/manageiq-content@d5448b4~...3f5aadb with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
lfu
approved these changes
Mar 25, 2020
|
@tinaafitz look ok? |
tinaafitz
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method refactoring and test creation.
This PR is based on the issue below.
ManageIQ/manageiq#12038
@miq-bot add_label refactoring
@miq-bot assign @tinaafitz