Floe features not yet supported #1817
Conversation
|
|
||
| ### Floe Features Not Yet Supported | ||
|
|
||
| The following are not yet supported for Floe: | ||
| - Parallel State | ||
| - Map State Fields: | ||
| - ItemReader | ||
| - ItemSelector/ItemBatcher | ||
| - ResultWriter |
There was a problem hiding this comment.
I see on line 167 we say we don't support Map and Parallel, can you update this to say we don't support these four Map state fields and we can merge this once we pull in a new release of floe?
nasark
force-pushed
the
floe_supported_features
branch
2 times, most recently
from
f632707 to
4fd3ad0
Compare
|
|
||
| ### Unsupported States Language Features | ||
|
|
||
| The following are not yet supported for Floe: | ||
| - Map State Fields: | ||
| - ItemReader |
There was a problem hiding this comment.
Can you replace the section up here https://github.com/ManageIQ/manageiq-documentation/pull/1817/files#diff-a944ad335565b3b6f0c1776d24ce585d3b42531e2d45bc20a5eaab1950a871e4R170-R179 with this?
nasark
force-pushed
the
floe_supported_features
branch
from
4fd3ad0 to
17f93c6
Compare
| ### Supported States Language Features | ||
| The following are supported: | ||
| - Parallel State | ||
| - Map State Fields: | ||
| - ItemProcessor | ||
| - ItemsPath | ||
| - ResultWriter | ||
| - MaxConcurrency | ||
| - ToleratedFailurePercentage | ||
| - ToleratedFailureCount |
There was a problem hiding this comment.
I think we can probably just drop this entirely, the goal is to support the whole states-language spec and we're pretty close so the list of what isn't supported is a whole lot shorter than what is.
| ### Supported States Language Features | |
| The following are supported: | |
| - Parallel State | |
| - Map State Fields: | |
| - ItemProcessor | |
| - ItemsPath | |
| - ResultWriter | |
| - MaxConcurrency | |
| - ToleratedFailurePercentage | |
| - ToleratedFailureCount |
nasark
force-pushed
the
floe_supported_features
branch
2 times, most recently
from
9270e24 to
3643dae
Compare
There was a problem hiding this comment.
LGTM, will merge this when ManageIQ/manageiq-providers-workflows#119 is merged
|
@Fryguy beat me to it :D |
| @@ -165,7 +165,15 @@ Workflows must be authored in Amazon State Languages (ASL) format. As part of au | |||
|
|
|||
| The workflow code must be in the Amazon States Language (ASL) format and follow its supported specifications. For more information about Amazon States Language and its specification, see [Amazon States Language Guide](https://states-language.net/). | |||
|
|
|||
| **Note**: The current implementation of the Amazon States Language does not support **Map** and **Parallel** states. | |||
| **Note**: The current implementation of the Amazon States Language does not support certain **Map** states. See [Unsupported States Language Features](#unsupported-states-language-features). | |||
There was a problem hiding this comment.
Change to:
For more information, see Unsupported States Language Features.
| **Note**: The current implementation of the Amazon States Language does not support **Map** and **Parallel** states. | ||
| **Note**: The current implementation of the Amazon States Language does not support certain **Map** states. See [Unsupported States Language Features](#unsupported-states-language-features). | ||
|
|
||
| #### Unsupported States Language Features |
There was a problem hiding this comment.
Unsupported States Language features
There was a problem hiding this comment.
Hey @qahmed1998 this PR is already merged if you want to make changes you can open a new pull request
|
Skipping backport to |
We should let users know what is not supported yet, based on ManageIQ/floe#241
@miq-bot assign @agrare
@miq-bot add_label enhancement
@miq-bot add_reviewer @agrare