Handle missing networkPerformance and "X Gpbs" #871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updated AWS database instance types list has some depreacted types without a networkPerformance value. The old code also wasn't properly handling the "X Gpbs" value only "X Gigabit" which was causing some values to be set as `:20_gbps` instead of `:very_high`
agrare
commented
Oct 28, 2024
Comment on lines
+11
to
+12
| network_performance = instance["networkPerformance"] | ||
| network_performance = network_performance.match?(/(\d+ Gigabit)|(\d+ Gbps)/) ? :very_high : network_performance.downcase.tr(' ', '_').to_sym if network_performance |
There was a problem hiding this comment.
I'm not sure that :very_high is better than :25_gigabit especially with the number of >1gbps continuing to increase we're losing out on some valuable information. I figured I'd fix it so that we were consistent then change it in the future.
There was a problem hiding this comment.
Actually it looks like we don't display this anywhere...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated AWS database instance types list has some depreacted types without a networkPerformance value.
The old code also wasn't properly handling the "X Gpbs" value only "X Gigabit" which was causing some values to be set as
:20_gbpsinstead of:very_high