Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Gbps in AWS database types #873

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

nasark
Copy link
Member

@nasark nasark commented Oct 28, 2024

We were handling Gigabit in network_performance values but not properly handling cases where Gbps is used

@miq-bot add_label bug
@miq-bot assign @agrare
@miq-bot add_reviewer @agrare

@agrare
Copy link
Member

agrare commented Oct 28, 2024

With this applied locally I see these:

$ grep network_performance db/fixtures/aws_database_types.yml | egrep -v 'high|low|moderate'
  :network_performance: :12_gigabit
  :network_performance: :25,000_mbps
  :network_performance: :up_to_10,000_mbps
  :network_performance: :10,000_mbps

Seems like another case or two we might need to cover in the regex

@nasark nasark force-pushed the aws_db_types_nil_network_performance branch from dadf3a9 to ec18bdc Compare October 28, 2024 18:41
@agrare agrare merged commit 2f931b3 into ManageIQ:master Oct 30, 2024
4 checks passed
@Fryguy
Copy link
Member

Fryguy commented Nov 4, 2024

Backported to radjabov in commit 2324e33.

commit 2324e33ea63416c4619bd4da884e217f507e2212
Author: Adam Grare <[email protected]>
Date:   Wed Oct 30 10:52:26 2024 -0400

    Merge pull request #873 from nasark/aws_db_types_nil_network_performance
    
    Handle Gbps in AWS database types
    
    (cherry picked from commit 2f931b37bbfa91ab2b5cd3403a32fd6b84f93b46)

Fryguy pushed a commit that referenced this pull request Nov 4, 2024
Handle Gbps in AWS database types

(cherry picked from commit 2f931b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants