Rename 'Ansible Tower' to 'Ansible Automation Platform' #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Dec 11, 2024
| @@ -15,8 +15,8 @@ def run_with_miq_job(options, userid = nil) | |||
| end | |||
|
|
|||
| def self.display_name(number = 1) | |||
| n_('Job Template (Ansible Tower)', 'Job Templates (Ansible Tower)', number) | |||
| n_('Job Template (Ansible Automation Platform)', 'Job Templates (Ansible Automation Platform)', number) | |||
There was a problem hiding this comment.
For a follow-up but I wonder how many of these can be dropped if we just did
Suggested change
| n_('Job Template (Ansible Automation Platform)', 'Job Templates (Ansible Automation Platform)', number) | |
| n_("Job Template (#{module_parent.description})", "Job Templates (#{module_parent.description})", number) |
in the base AWX class
There was a problem hiding this comment.
Because there's the n_, you can't use interpolation, but you could do:
Suggested change
| n_('Job Template (Ansible Automation Platform)', 'Job Templates (Ansible Automation Platform)', number) | |
| n_('Job Template (%{provider_description}', 'Job Templates (%{provider_description)', number % {:provider_description => module_parent.description} |
agrare
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@miq-bot assign @agrare
@miq-bot add_reviewer @agrare