Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary display_name functions #319

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Remove unnecessary display_name functions #319

merged 1 commit into from
Dec 13, 2024

Conversation

nasark
Copy link
Member

@nasark nasark commented Dec 13, 2024 •
edited by agrare
Loading

We can just use the corresponding function in the AWX parent class

Depends on:

@miq-bot assign @agrare
@miq-bot add_label refactoring
@miq-bot add_reviewer @Fryguy, @agrare

@nasark nasark requested review from agrare and Fryguy as code owners December 13, 2024 20:06
@nasark nasark mentioned this pull request Dec 13, 2024
Merged
1 task
agrare
agrare approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

>> ManageIQ::Providers::AnsibleTower::AutomationManager::ConfiguredSystem.display_name
=> "Configured System (Ansible Automation Platform)

@agrare agrare merged commit 9a3d57f into ManageIQ:master Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees

@agrare agrare

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nasark @agrare @miq-bot