Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common Ansible template parent class in runner #36

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

nasark
Copy link
Member

@nasark nasark commented Sep 19, 2024

Since Ansible workflow templates are not under the ExternalAutomationManager parent class this would cause the following error when running a workflow template

/Users/nasarkhan/.rvm/gems/ruby-3.0.1/gems/activerecord-7.0.8.4/lib/active_record/core.rb:284:in `find': Couldn't find ManageIQ::Providers::ExternalAutomationManager::ConfigurationScript with 'id'=30 (ActiveRecord::RecordNotFound)
	from /Users/nasarkhan/Documents/manageiq/app/models/job/state_machine.rb:52:in `signal'
	from /Users/nasarkhan/.rvm/gems/ruby-3.0.1/bundler/gems/manageiq-providers-ansible_tower-7d2a7bb7943d/app/models/manageiq/providers/ansible_tower/automation_manager/configuration_workflow.rb:9:in `run_with_miq_job'

Switching to a common parent class in AutomationManager::ConfigurationScript resolves the issue

@miq-bot add_label bug, radjabov/yes?
@miq-bot assign @agrare
@miq-bot add_reviewer @jrafanie @agrare

@miq-bot miq-bot added bug Something isn't working radjabov/yes? labels Sep 19, 2024
@miq-bot
Copy link
Member

miq-bot commented Sep 19, 2024

@nasark Cannot add the following reviewer because they are not recognized: jrafanie agrare

@agrare agrare merged commit 74985d5 into ManageIQ:master Sep 19, 2024
4 checks passed
@Fryguy
Copy link
Member

Fryguy commented Oct 8, 2024

Backported to radjabov in commit 6933828.

commit 6933828f57b88b8e0c953c6c9fafbaf3592ac6af
Author: Adam Grare <[email protected]>
Date:   Thu Sep 19 12:29:32 2024 -0400

    Merge pull request #36 from nasark/use_common_template_class_in_runner
    
    Use common Ansible template parent class in runner
    
    (cherry picked from commit 74985d5a8a2ff12da592aaa4f3c7db1daa4abef2)

Fryguy pushed a commit that referenced this pull request Oct 8, 2024
Use common Ansible template parent class in runner

(cherry picked from commit 74985d5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working radjabov/backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants