Always create opentofu_worker miq_workers record #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit agrare@25c64a1 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
2 tasks
agrare
changed the title
Fryguy
approved these changes
Aug 22, 2024
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Aug 22, 2024
Always create opentofu_worker miq_workers record (cherry picked from commit d13296d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually the goal is for MiqServer to create worker records for all worker types but for now it is simpler to do this specifically for the OpentofuWorker
This still depends on a change in core to assign a system_uid (pod_name) to the worker record that gets created, but simplifies everything else by not changing how existing Rails workers with run_single_worker.rb work.
Required for ManageIQ/manageiq#23112
Fixes #67