Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse terraform template & create new service dialog with parsed input vars #75
Parse terraform template & create new service dialog with parsed input vars #75
Changes from 20 commits
4b6a0eb
067f4f4
53909c9
e377dbe
1573aac
30a006b
398081a
d13a115
f934749
2a983a1
6020047
32c8387
e444122
72d7c7e
fca9d3d
ea7945d
6431953
a24a5f6
5444610
4fe3adf
f965829
180af2c
82b6095
9d0748c
8945d55
aacd630
9719425
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised there isn't a way to do this in the base
EmbeddedAutomationManager::ConfigurationScript
class, ideally we could have awith_git_repository
which took a block and automatically handled the tempdir creation and cleanup.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let me do this another PR, rather than is PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised as well - thought we had this functionality, because all git repositories will need this (since we use bare repos)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use
send
here? This method doesn't appear to be private and the method name isn't dynamic so I think you can justThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This came from ansible implementation, myself was puzzled why 'send' ?
simply did not fix what was not broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 That's because their create_dialogs instance method is private, that isn't a good reason to use send but that is why it is needed there and not here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a very long argument list :) can we one-line this?