Add methods to fetch terraform stdout for showing in UI.

app/models/manageiq/providers/embedded_terraform/automation_manager/stack.rb

@@ -83,29 +83,35 @@ def raw_stdout_via_worker(userid, format = 'txt')
 
   def raw_stdout(format = 'txt')
     case format
-    when "json" then raw_stdout_json
     when "html" then raw_stdout_html
     else             raw_stdout_txt
     end
   end
 
-  def raw_stdout_json
-    raw_stdout_txt.split("\n")
-  end
-
   def raw_stdout_txt
-    job = miq_task.job
-    terraform_stack_id = job.options[:terraform_stack_id]
+    data = terraform_runner_stack_data
 
-    return if terraform_stack_id.blank?
+    return '' if data.nil?
 
-    response = Terraform::Runner.fetch_result_by_stack_id(terraform_stack_id)
-    response.message
+    data.message
   end
 
   def raw_stdout_html
     text = raw_stdout_txt
     text = _("No output available") if text.blank?
     TerminalToHtml.render(text)
   end
+
+  private
+
+  def terraform_runner_stack_data
+    return if miq_task.nil? || miq_task.job.nil?
+
+    job = miq_task.job
+    terraform_stack_id = job.options[:terraform_stack_id]
+
+    return if terraform_stack_id.blank?
+
+    Terraform::Runner.fetch_result_by_stack_id(terraform_stack_id)
+  end
 end

spec/models/manageiq/providers/embedded_terraform/automation_manager/stack_spec.rb

@@ -30,4 +30,125 @@
       end
     end
   end
+
+  describe "#raw_stdout" do
+    let(:stack) { FactoryBot.create(:terraform_stack) }
+    let(:template) { FactoryBot.create(:terraform_template) }
+
+    context "when miq_task.job present" do
+      require 'webmock/rspec'
+      require 'json'
+      let(:terraform_runner_url) { "https://1.2.3.4:7000" }
+      let(:hello_world_retrieve_response) do
+        JSON.parse(File.read(File.join(__dir__, "../../../../../lib/terraform/runner/data/responses/hello-world-retrieve-success.json")))
+      end
+      let(:miq_task) do
+        miq_task = FactoryBot.create(:miq_task)
+        miq_task.job = job
+        miq_task
+      end
+
+      let(:job) do
+        ManageIQ::Providers::EmbeddedTerraform::AutomationManager::Job.create_job(template, {}, {}, []).tap do |job|
+          job.state = "finished"
+          job.options = {
+            :terraform_stack_id => hello_world_retrieve_response['stack_id']
+          }
+        end
+      end
+
+      let(:terraform_runner_stdout) { hello_world_retrieve_response['message'] }
+      let(:terraform_runner_stdout_html) { TerminalToHtml.render(terraform_runner_stdout) }
+
+      retrieve_stub = nil
+
+      before do
+        stack.miq_task = miq_task
+
+        stub_const("ENV", ENV.to_h.merge("TERRAFORM_RUNNER_URL" => terraform_runner_url))
+
+        retrieve_stub = stub_request(:post, "#{terraform_runner_url}/api/stack/retrieve")
+                        .with(:body => hash_including({:stack_id => hello_world_retrieve_response['stack_id']}))
+                        .to_return(
+                          :status => 200,
+                          :body   => hello_world_retrieve_response.to_json
+                        )
+      end
+
+      it "json" do
+        expect(stack.raw_stdout("json")).to eq terraform_runner_stdout
+
+        expect(retrieve_stub).to(have_been_requested.times(1))
+      end
+
+      it "txt" do
+        expect(stack.raw_stdout("txt")).to eq terraform_runner_stdout
+
+        expect(retrieve_stub).to(have_been_requested.times(1))
+      end
+
+      it "html" do
+        expect(stack.raw_stdout("html")).to eq terraform_runner_stdout_html
+
+        expect(retrieve_stub).to(have_been_requested.times(1))
+      end
+
+      it "nil" do
+        expect(stack.raw_stdout).to eq terraform_runner_stdout
+
+        expect(retrieve_stub).to(have_been_requested.times(1))
+      end
+    end
+
+    shared_examples_for "terraform runner stdout not available from miq_task" do
+      it "json" do
+        expect(stack.raw_stdout("json")).to eq("")
+      end
+
+      it "txt" do
+        expect(stack.raw_stdout("txt")).to eq ""
+      end
+
+      it "html" do
+        expect(stack.raw_stdout("html")).to include <<~EOHTML
+          <div class='term-container'>
+          No output available
+          </div>
+        EOHTML
+      end
+
+      it "nil" do
+        expect(stack.raw_stdout).to eq ""
+      end
+    end
+
+    context "when miq_task.job is missing" do
+      before do
+        stack.miq_task = nil
+      end
+
+      it_behaves_like "terraform runner stdout not available from miq_task"
+    end
+
+    context "when miq_task present, but missing miq_task.job" do
+      before do
+        stack.miq_task = FactoryBot.create(:miq_task)
+        stack.miq_task.job = nil
+      end
+
+      it_behaves_like "terraform runner stdout not available from miq_task"
+    end
+
+    context "when miq_task.job.options present but missing terraform_stack_id" do
+      before do
+        stack.miq_task = FactoryBot.create(:miq_task)
+        stack.miq_task.job = ManageIQ::Providers::EmbeddedTerraform::AutomationManager::Job.create_job(template, {}, {}, []).tap do |job|
+          job.state = "waiting_to_start"
+          job.options = {}
+        end
+      end
+
+      it_behaves_like "terraform runner stdout not available from miq_task"
+    end
+  end
 end