Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supports terminate feature #137

Merged
merged 1 commit into from
May 29, 2020
Merged

Add supports terminate feature #137

merged 1 commit into from
May 29, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented May 28, 2020

@agrare agrare requested a review from Fryguy as a code owner May 28, 2020 20:20
@agrare agrare added the bug label May 28, 2020
@agrare agrare mentioned this pull request May 28, 2020
Merged
8 tasks
@agrare agrare changed the title Add supports terminate feature [WIP] Add supports terminate feature May 28, 2020
@miq-bot miq-bot added the wip label May 28, 2020
@agrare agrare force-pushed the add_supports_terminate_feature branch from 7d1a8a9 to 2e519b6 Compare May 29, 2020 12:23
@agrare agrare changed the title [WIP] Add supports terminate feature Add supports terminate feature May 29, 2020
@agrare agrare added jansa/yes? and removed wip labels May 29, 2020
@miq-bot
Copy link
Member

miq-bot commented May 29, 2020

Checked commit agrare@2e519b6 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍰

agrare added a commit to agrare/manageiq-cross_repo-tests that referenced this pull request May 29, 2020
@agrare
Test refactoring supports_terminate?
378a81b 
Testing:
ManageIQ/manageiq#20222
ManageIQ/manageiq-providers-amazon#626
ManageIQ/manageiq-providers-azure#397
ManageIQ/manageiq-providers-google#137
ManageIQ/manageiq-providers-kubevirt#164
ManageIQ/manageiq-providers-openstack#598
ManageIQ/manageiq-providers-ovirt#497
ManageIQ/manageiq-providers-vmware#584
@agrare agrare mentioned this pull request May 29, 2020
Closed
@djberg96 djberg96 self-requested a review May 29, 2020 15:58
@djberg96 djberg96 merged commit f36cf97 into ManageIQ:master May 29, 2020
@agrare agrare deleted the add_supports_terminate_feature branch May 29, 2020 16:13
simaishi pushed a commit that referenced this pull request May 29, 2020
@simaishi
Merge pull request #137 from agrare/add_supports_terminate_feature
420e6eb 
Add supports terminate feature

(cherry picked from commit f36cf97)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit 420e6eb03cadc10a6120c5b1c8ca2db999e2af4c
Author: Daniel Berger <[email protected]>
Date:   Fri May 29 11:58:26 2020 -0400

    Merge pull request #137 from agrare/add_supports_terminate_feature

    Add supports terminate feature

    (cherry picked from commit f36cf97c652bc9668c10dcab4081fc069b16665e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djberg96 djberg96 djberg96 approved these changes

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees
No one assigned
Labels
bug jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agrare @miq-bot @simaishi @djberg96 @chessbyte