-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Prometheus Alerts MonitoringManager #507
Conversation
33dae50
to
fe9fc65
Compare
kicking |
fe9fc65
to
8388109
Compare
ok, looks like the test failure is trivial but legit. The list has changed:
Confused why this is showing up here though. |
The test is correct I forgot to remove the systemd unit files for the deleted worker classes |
8388109
to
8c101b1
Compare
Checked commit agrare@8c101b1 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
This pull request is not mergeable. Please rebase and repush. |
Closing in favor of #518 |
This was only supported on OCPv3 and is not expected to be reimplemented in the future.
Based on: #506
NOTE I split this out from #506 because we might want to backport that (it causes user confusion) where as this is strictly a backend cleanup that also will require some data migrations to delete any old records.