Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Prometheus Alerts MonitoringManager #507

Closed
wants to merge 1 commit into from

Conversation

agrare
Copy link
Member

@agrare agrare commented Sep 22, 2023

This was only supported on OCPv3 and is not expected to be reimplemented in the future.

Based on: #506

NOTE I split this out from #506 because we might want to backport that (it causes user confusion) where as this is strictly a backend cleanup that also will require some data migrations to delete any old records.

@kbrock
Copy link
Member

kbrock commented Sep 29, 2023

kicking

@kbrock kbrock closed this Sep 29, 2023
@kbrock kbrock reopened this Sep 29, 2023
@agrare agrare force-pushed the delete_monitoring_manager branch from fe9fc65 to 8388109 Compare October 1, 2023 16:00
@kbrock
Copy link
Member

kbrock commented Oct 3, 2023

ok, looks like the test failure is trivial but legit. The list has changed:

       the missing elements were: [
         "manageiq-providers-openshift_monitoring_manager_event_catcher.target",
         "manageiq-providers-openshift_monitoring_manager_event_catcher@.service"
       ]
     # ./spec/manageiq/spec/models/miq_worker/systemd_common_spec.rb:19:in `block (3 levels) in <top (required)>'

Confused why this is showing up here though.
Maybe a rebase would fix?

@agrare
Copy link
Member Author

agrare commented Oct 5, 2023

The test is correct I forgot to remove the systemd unit files for the deleted worker classes

@agrare agrare force-pushed the delete_monitoring_manager branch from 8388109 to 8c101b1 Compare October 5, 2023 15:48
@miq-bot
Copy link
Member

miq-bot commented Oct 5, 2023

Checked commit agrare@8c101b1 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@miq-bot miq-bot added the stale label Jan 8, 2024
@miq-bot
Copy link
Member

miq-bot commented Jan 8, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Feb 6, 2024

This pull request is not mergeable. Please rebase and repush.

@agrare agrare closed this Mar 1, 2024
@agrare
Copy link
Member Author

agrare commented Mar 1, 2024

Closing in favor of #518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants