[WIP] Add some debugging for kubeclient

[jrafanie]

Kubeclient uses RestClient for 4.x versions for the main connection but the http gem for watches. On master, kubeclient uses faraday for main connections. This commit provides a way to patch restclient/faraday and http to add logging of request/response.

TODO: We will need to provide a way to sanitize passwords and possibly other information.

[jrafanie]

I'm seeing "body has already been consumed" locally with this patch, specifically, the WatchThread prepend:

[----] E, [2023-10-25T14:18:08.053516 #19540:f89918] ERROR -- evm: MIQ(ManageIQ::Providers::Openshift::ContainerManager::RefreshWorker::WatchThread#collector_thread) Watch thread for build_configs failed: body has already been consumed
[----] E, [2023-10-25T14:18:08.053723 #19540:f89918] ERROR -- evm: [HTTP::StateError]: body has already been consumed  Method:[block (2 levels) in <class:LogProxy>]
[----] E, [2023-10-25T14:18:08.053792 #19540:f89918] ERROR -- evm: /Users/joerafaniello/.gem/ruby/3.0.6/gems/http-5.1.1/lib/http/response/body.rb:67:in `stream!'
/Users/joerafaniello/.gem/ruby/3.0.6/gems/http-5.1.1/lib/http/response/body.rb:29:in `readpartial'
/Users/joerafaniello/.gem/ruby/3.0.6/gems/http-5.1.1/lib/http/response/body.rb:37:in `each'
/Users/joerafaniello/.gem/ruby/3.0.6/gems/kubeclient-4.11.0/lib/kubeclient/watch_stream.rb:25:in `each'
/Users/joerafaniello/Code/manageiq-providers-kubernetes/app/models/manageiq/providers/kubernetes/container_manager/refresh_worker/watch_thread.rb:56:in `collector_thread'
/Users/joerafaniello/Code/manageiq-providers-kubernetes/app/models/manageiq/providers/kubernetes/container_manager/refresh_worker/watch_thread.rb:26:in `block in start!'
D, [2023-10-25T14:18:08.054134 #19540] DEBUG -- : Audit-Id: 28cab2dd-30c1-4865-ae6b-2f53cd4c50bd

This still needs to be resolved.

[Fryguy]

Should this be STDERR, to match the $stderr used in the prepended patch?

[jrafanie]

👍 it's blowing up so I've shelved it for now.

[miq-bot]

Checked commit jrafanie@1237e0d with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 6 offenses detected

app/models/manageiq/providers/kubernetes/container_manager.rb

• ❗ - Line 659, Col 42 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• ❗ - Line 661, Col 24 - Style/GlobalStdStream - Use $stdout instead of STDOUT.

lib/manageiq/providers/kubernetes/debug_kubeclient_watch.rb

• ❗ - Line 8, Col 21 - Style/HashSyntax - Use hash rockets syntax.
• ❗ - Line 8, Col 31 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.
• ❗ - Line 8, Col 32 - Style/HashSyntax - Use hash rockets syntax.
• ❗ - Line 8, Col 59 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[kbrock]

would a tap fix this?

i.e.:

Suggested change

	super.use(logging: { logger: Logger.new($stderr) })
	super.tap { |client| client.use(:logging => {:logger => Logger.new($stderr) }) }

... sorry. flyby ...

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[jrafanie]

Stale, closing for now