Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parent_manager class to point to Kubernetes::ContainerManager #231

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix parent_manager class to point to Kubernetes::ContainerManager #231

merged 1 commit into from
Mar 4, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Mar 1, 2024 •
edited
Loading

@agrare agrare requested a review from Fryguy as a code owner March 1, 2024 18:41
This was referenced Mar 1, 2024
Merged
Merged
@agrare agrare force-pushed the fix_parent_manager_class branch from ab24228 to 0aba7d3 Compare March 1, 2024 19:07
@miq-bot
Copy link
Member

miq-bot commented Mar 1, 2024

Checked commit agrare@0aba7d3 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 👍

@agrare
Copy link
Member Author

agrare commented Mar 1, 2024

This can be merged independently from the rest

@agrare agrare closed this Mar 4, 2024
@agrare agrare reopened this Mar 4, 2024
@Fryguy Fryguy merged commit 71a63af into ManageIQ:master Mar 4, 2024
5 of 6 checks passed
@Fryguy Fryguy self-assigned this Mar 4, 2024
@agrare agrare deleted the fix_parent_manager_class branch March 4, 2024 19:40
@Fryguy
Copy link
Member

Fryguy commented Mar 6, 2024

Backported to radjabov in commit ed7c9de.

commit ed7c9de98a3328e9aa5d4f37c3b561fc385378b3
Author: Jason Frey <[email protected]>
Date:   Mon Mar 4 14:39:40 2024 -0500

    Merge pull request #231 from agrare/fix_parent_manager_class
    
    Fix parent_manager class to point to Kubernetes::ContainerManager
    
    (cherry picked from commit 71a63af851ddecb356bd13cf8a84a26f1e96a105)

Fryguy added a commit that referenced this pull request Mar 6, 2024
@Fryguy
Merge pull request #231 from agrare/fix_parent_manager_class
ed7c9de 
Fix parent_manager class to point to Kubernetes::ContainerManager

(cherry picked from commit 71a63af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy approved these changes

Assignees

@Fryguy Fryguy

Labels
bug radjabov/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrare @miq-bot @Fryguy