[WIP] replace fog-kubevirt with kubeclient #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2024
agrare
force-pushed
the
replace_fog_kubevirt_with_kubeclient
branch
from
fe57918 to
aeaf256
Compare
Fryguy
reviewed
Dec 11, 2024
Comment on lines
+46
to
+47
| @nodes = kube_client.get_nodes | ||
| @vms = kubevirt_client.get_virtual_machines | ||
| @vm_instances = kubevirt_client.get_virtual_machine_instances | ||
| @templates = openshift_template_client.get_templates |
There was a problem hiding this comment.
More out of curiosity, and not for this PR, but could we collect these from the clients in parallel?
agrare
force-pushed
the
replace_fog_kubevirt_with_kubeclient
branch
from
aeaf256 to
09051bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#245