Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Upgrade package to 2.0.1" #106

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented May 23, 2024

Reverts #104

This was accidentally sent to master, but the fix only was needed on morphy. See #105.

@Fryguy Fryguy added the bug Something isn't working label May 23, 2024
@Fryguy Fryguy requested a review from agrare as a code owner May 23, 2024 14:48
@miq-bot
Copy link
Member

miq-bot commented May 23, 2024

Checked commit cdf6966 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy
Copy link
Member Author

Fryguy commented May 23, 2024

Ugh the failures are because I used the revert button and the setup code basically says "if this is a branch on the main repo and it's not master, renovate, or dependabot, then it must be a release branch, so I expect a Gemfile.lock.release". I need to change that to account for revert branches as well. 😞

@Fryguy
Copy link
Member Author

Fryguy commented May 23, 2024

PR on core that will fix the tests here: ManageIQ/manageiq#23047

@agrare agrare closed this May 23, 2024
@agrare agrare reopened this May 23, 2024
@agrare
Copy link
Member

agrare commented May 23, 2024

CI / ci (3.0) (push) Failing after 4m is from an older GHA run, current CI / ci (3.0) (pull_request) is green

@agrare agrare merged commit 2734b9d into master May 23, 2024
6 of 8 checks passed
@agrare agrare deleted the revert-104-upgrade-ip-package branch May 23, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants