Add Openstack prefix to Cinder and Swift manager descriptions #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasark
changed the title
agrare
reviewed
Dec 11, 2024
| @@ -58,11 +58,11 @@ def self.ems_type | |||
| end | |||
|
|
|||
| def self.description | |||
| @description ||= "Cinder ".freeze | |||
| @description ||= "Openstack Cinder ".freeze | |||
There was a problem hiding this comment.
The CloudManager and NetworkManager both use OpenStack can you match that for all of these?
nasark
force-pushed
the
openstack_prefix_cinder_swift_manager_descriptions
branch
from
ee32950 to
5d78689
Compare
Fryguy
reviewed
Dec 11, 2024
| @@ -58,11 +58,11 @@ def self.ems_type | |||
| end | |||
|
|
|||
| def self.description | |||
| @description ||= "Cinder ".freeze | |||
| @description ||= "OpenStack Cinder ".freeze | |||
There was a problem hiding this comment.
I think we should drop the trailing spaces.
Suggested change
| @description ||= "OpenStack Cinder ".freeze | |
| @description ||= "OpenStack Cinder".freeze |
|
Also, since we're making this change in a base provider, please run cross-repo tests with the descendant providers |
nasark
force-pushed
the
openstack_prefix_cinder_swift_manager_descriptions
branch
from
5d78689 to
3135ac9
Compare
|
@miq-bot cross-repo-test manageiq-providers-ibm_cic, manageiq-providers-ibm_power_vc |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Dec 12, 2024
From Pull Request: ManageIQ/manageiq-providers-openstack#898
agrare
approved these changes
Dec 12, 2024
|
|
|
Oh we need a fix like #897 in those also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@miq-bot assign @agrare
@miq-bot add_reviewer @agrare