Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supports terminate feature #497

Merged
merged 1 commit into from
May 29, 2020
Merged

Add supports terminate feature #497

merged 1 commit into from
May 29, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented May 28, 2020

@agrare agrare added the bug label May 28, 2020
@agrare agrare mentioned this pull request May 28, 2020
Merged
8 tasks
@agrare agrare changed the title Add supports terminate feature [WIP] Add supports terminate feature May 28, 2020
@miq-bot miq-bot added the wip label May 28, 2020
@agrare agrare force-pushed the add_supports_terminate_feature branch from b7d9f3c to ba9b1f5 Compare May 29, 2020 12:34
@agrare agrare changed the title [WIP] Add supports terminate feature Add supports terminate feature May 29, 2020
@agrare agrare added jansa/yes? and removed wip labels May 29, 2020
@miq-bot
Copy link
Member

miq-bot commented May 29, 2020

Checked commit agrare@ba9b1f5 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 👍

agrare added a commit to agrare/manageiq-cross_repo-tests that referenced this pull request May 29, 2020
@agrare
Test refactoring supports_terminate?
378a81b 
Testing:
ManageIQ/manageiq#20222
ManageIQ/manageiq-providers-amazon#626
ManageIQ/manageiq-providers-azure#397
ManageIQ/manageiq-providers-google#137
ManageIQ/manageiq-providers-kubevirt#164
ManageIQ/manageiq-providers-openstack#598
ManageIQ/manageiq-providers-ovirt#497
ManageIQ/manageiq-providers-vmware#584
@agrare agrare mentioned this pull request May 29, 2020
Closed
@chessbyte chessbyte merged commit d48b57f into ManageIQ:master May 29, 2020
@agrare agrare deleted the add_supports_terminate_feature branch May 29, 2020 16:30
simaishi pushed a commit that referenced this pull request May 29, 2020
@chessbyte @simaishi
Merge pull request #497 from agrare/add_supports_terminate_feature
2074d59 
Add supports terminate feature

(cherry picked from commit d48b57f)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit 2074d5955a003b224ad06874ef3ef792906a8de9
Author: Oleg Barenboim <[email protected]>
Date:   Fri May 29 12:27:36 2020 -0400

    Merge pull request #497 from agrare/add_supports_terminate_feature

    Add supports terminate feature

    (cherry picked from commit d48b57f4e3a184fbc28d32224218765c58f7f350)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borod108 borod108 Awaiting requested review from borod108

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

@gekorob gekorob Awaiting requested review from gekorob

@mwperina mwperina Awaiting requested review from mwperina

Assignees

@chessbyte chessbyte

Labels
bug jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agrare @miq-bot @simaishi @chessbyte