Remove N+1 from assign_ems_create_on #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Oct 20, 2020
Fryguy
force-pushed
the
performance_assign_ems_created_on
branch
from
5d8b658 to
42b7d6e
Compare
|
I can add specs around this, but in the other discussion (#655 (comment)) we thought maybe dropping this altogether? I figured let's decide how we want to go first before I spend time writing specs. |
|
Checked commit Fryguy@42b7d6e with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint app/models/manageiq/providers/vmware/infra_manager.rb
|
|
I'm closing this in preference to dropping the feature entirely as per the conversation in #655 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #655
@agrare Please review.
I didn't test this directly because I wasn't sure how, and I don't think there's specs around it?