Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert console_supported? to supports? #864

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Mar 8, 2023

@kbrock kbrock force-pushed the supports_console branch from c8ee806 to 8ca203f Compare March 23, 2023 01:21
… supports

vnc, webmks, and console are not consistent
webmks also adds login validation checking.

Added the vm must be running check from :launch_{}_console
feature. That feature has been rolled into :{}_console
@kbrock kbrock force-pushed the supports_console branch from 8ca203f to 2e9ced0 Compare March 23, 2023 01:25
@miq-bot miq-bot added the stale label Jun 26, 2023
@miq-bot
Copy link
Member

miq-bot commented Jun 26, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot closed this Oct 2, 2023
@miq-bot
Copy link
Member

miq-bot commented Oct 2, 2023

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@kbrock
Copy link
Member Author

kbrock commented Oct 3, 2023

outstanding:
This needs to be split up.
the PR got away from me

@kbrock kbrock reopened this Oct 3, 2023
@kbrock kbrock removed the stale label Oct 3, 2023
@miq-bot
Copy link
Member

miq-bot commented Oct 3, 2023

Checked commits kbrock/manageiq-providers-vmware@0aef0d0~...2e9ced0 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
5 files checked, 3 offenses detected

app/models/manageiq/providers/vmware/infra_manager/vm/remote_console.rb

  • 💣 💥 🔥 🚒 - Line 155, Col 1 - Lint/Syntax - unexpected token kEND
    (Using Ruby 2.6 parser; configure using TargetRubyVersion parameter, under AllCops)
  • 💣 💥 🔥 🚒 - Line 17, Col 27 - Lint/Syntax - unexpected token tLCURLY
    (Using Ruby 2.6 parser; configure using TargetRubyVersion parameter, under AllCops)
  • 💣 💥 🔥 🚒 - Line 17, Col 58 - Lint/Syntax - unexpected token tRCURLY
    (Using Ruby 2.6 parser; configure using TargetRubyVersion parameter, under AllCops)

@miq-bot miq-bot added the stale label Jan 8, 2024
@miq-bot
Copy link
Member

miq-bot commented Jan 8, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

3 similar comments
@miq-bot
Copy link
Member

miq-bot commented Apr 15, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Jul 22, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Nov 1, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants