Fix VM Provision datastore location class #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE this is failing because the storage_vmware factory doesn't have the proper class set so we don't have the ems_ref_obj method defined. |
When building the `VirtualMachineRelocateSpec` the `datastore` property is a `ManagedObjectReference` to a `Datastore`. We were setting the value to a simple `String` rather than a `VimString` with the proper `xsiType`/`vimType`. This would have broken when we moved from having VimString in ems_ref as a serialized yaml column and added ems_ref_obj.
agrare
force-pushed
the
fix_vm_provision_spec_location_datastore_class
branch
from
b13d024
to
b8e8f34
Compare
|
Checked commit agrare@b8e8f34 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Fryguy
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the
VirtualMachineRelocateSpecthedatastoreproperty is aManagedObjectReferenceto aDatastore. We were setting the value to a simpleStringrather than aVimStringwith the properxsiType/vimType.This would have broken when we moved from having VimString in ems_ref as a serialized yaml column and added ems_ref_obj.
This causes the clone to fail when using a vcsim (https://github.com/vmware/govmomi/tree/main/vcsim)
Depends on: