Set workflow description from asl comment #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
commented
Mar 29, 2024
| @@ -76,8 +76,26 @@ def sync_from_content(to_delete) | |||
| end | |||
|
|
|||
| def create_workflow_from_payload(name, payload) | |||
| floe_workflow, payload_error = | |||
| begin | |||
| Floe::Workflow.new(payload) | |||
There was a problem hiding this comment.
I had this depend on #59 because we were already loading the Floe::Workflow there
agrare
commented
Mar 29, 2024
| [nil, err.message] | ||
| end | ||
|
|
||
| comment = floe_workflow&.payload&.[]("Comment") |
There was a problem hiding this comment.
TODO I think having Floe::Workflow#comment accessor would be cleaner
There was a problem hiding this comment.
🙇 thanks!, released v0.10.0 with that change
agrare
force-pushed
the
set_workflow_description_from_asl_comment
branch
2 times, most recently
from
9c008e4 to
6f75795
Compare
|
Can we merge this without the sync PR? |
agrare
force-pushed
the
set_workflow_description_from_asl_comment
branch
from
6f75795 to
25b5c2c
Compare
agrare
changed the title
agrare
force-pushed
the
set_workflow_description_from_asl_comment
branch
from
25b5c2c to
57b8bf5
Compare
|
Okay rebased to not depend on #59 |
kbrock
reviewed
Apr 8, 2024
| nil | ||
| end | ||
|
|
||
| description = floe_workflow&.comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do something similar if you manually create a Workflow from a json payload since we don't have a file path, https://github.com/ManageIQ/manageiq-providers-workflows/blob/master/app/models/manageiq/providers/workflows/automation_manager/workflow.rb#L4 and I thought it'd add a nice "human readable" description