Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return descendent loader cache to regular privs #173

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Jul 22, 2021

related to ManageIQ/manageiq#20394

we were trying to overwrite the descenent loader cache
This was fixed in d4ecc500c8c ( ManageIQ/manageiq#21321 )

now we no longer need the special/explicit privileges

we were trying to overwrite the descenent loader cache
This was fixed in d4ecc500c8c ( ManageIQ/manageiq#21321 )

now we no longer need the special privileges
@kbrock kbrock added enhancement New feature or request wip labels Jul 22, 2021
@miq-bot
Copy link
Member

miq-bot commented Jul 22, 2021

Checked commit kbrock@b839921 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@kbrock kbrock changed the title [WIP] return descendent loader cache to regular privs Return descendent loader cache to regular privs Jul 22, 2021
@miq-bot miq-bot removed the wip label Jul 22, 2021
@kbrock
Copy link
Member Author

kbrock commented Jul 22, 2021

UNWIP:

installed this on an appliance and verified all are running.

Of note:
This really didn't do much. The permissions are the same before and after.
tmp/ and all files in it are owned by 'manageiq.manageiqso setting the ownership on this file in particular tomanageiq.manageiq` was a no-op.

I had tried to figure out if it made sense to have it owned by root but since this is a cached file, I think it does make sense to have it owned by manageiq even though we will never write to the file in production. This seems to go with @Fryguy reasoning around the file from what I could tell.

@@ -53,9 +53,6 @@ done
%attr(-,manageiq,manageiq) %{app_root}/config
%attr(-,manageiq,manageiq) %{app_root}/log
%attr(-,manageiq,manageiq) %{app_root}/tmp
## this is until we fix the code that auto writes this
## give kbrock a hard time if it is 2022 and this is still in here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With time to spare!

@Fryguy Fryguy merged commit a626067 into ManageIQ:master Jul 26, 2021
@Fryguy Fryguy assigned Fryguy and unassigned bdunne Jul 26, 2021
@kbrock kbrock deleted the descendent-loader-cache branch July 26, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants