Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create app_root/public/upload directory #175

Closed

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 2, 2021

The /var/www/miq/vmdb/public/upload directory was being created dynamically by the UI worker. The /var/www/miq/vmdb/public dir is owned by root and so the worker was throwing an exception trying to create a directory under it as the manageiq user which was preventing any application settings from being saved.

Fixes ManageIQ/manageiq#21359

@agrare
Copy link
Member Author

agrare commented Aug 2, 2021

Testing this out with a local rpm build now

@agrare agrare force-pushed the create_public_upload_directory branch from da1c803 to 6f2c03b Compare August 2, 2021 20:46
@agrare
Copy link
Member Author

agrare commented Aug 3, 2021

file /var/www/miq/vmdb/public/upload conflicts between attempted installs of manageiq-ui-13.0.0-20210802204721.el8.x86_64 and manageiq-core-13.0.0-20210802204721.el8.x86_64

Okay excluded from the core rpm

@agrare agrare force-pushed the create_public_upload_directory branch from 6f2c03b to 8c21680 Compare August 3, 2021 13:17
@agrare
Copy link
Member Author

agrare commented Aug 3, 2021

Okay looks good now:

[root@localhost vmdb]# ls -l public/ 
total 44
-rw-r--r--. 1 root     root       728 Aug  3 09:01 404.html
-rw-r--r--. 1 root     root       711 Aug  3 09:01 422.html
-rw-r--r--. 1 root     root       728 Aug  3 09:01 500.html
drwxr-xr-x. 8 root     root     16384 Aug  3 09:25 assets
-rw-r--r--. 1 root     root        41 Aug  3 09:01 custom.css
drwxr-xr-x. 9 root     root      4096 Aug  3 09:25 packs
drwxr-xr-x. 2 manageiq manageiq     6 Aug  3 09:18 pictures
drwxr-xr-x. 2 root     root        40 Aug  3 09:25 proxy_pages
-rw-r--r--. 1 root     root       204 Aug  3 09:01 robots.txt
drwxr-xr-x. 3 root     root        21 Aug  3 09:17 ui
drwxr-xr-x. 2 manageiq manageiq     6 Aug  3 09:18 upload

@agrare agrare requested a review from bdunne August 3, 2021 13:33
@agrare agrare added the bug Something isn't working label Aug 3, 2021
@bdunne
Copy link
Member

bdunne commented Aug 3, 2021

Looks like Keenan got started with this in #174

@agrare
Copy link
Member Author

agrare commented Aug 4, 2021

👍 will close in favor of that

@agrare agrare closed this Aug 4, 2021
@agrare agrare deleted the create_public_upload_directory branch August 4, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Applications Settings on an appliance blows up with Permission Denied
2 participants