[QUINTEROS] Fix issues with RPM versioning after merge of master into quinteros #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
commented
Oct 30, 2023
| @@ -15,7 +15,7 @@ RUN ARCH=$(uname -m) && \ | |||
| http://mirror.centos.org/centos/8-stream/BaseOS/${ARCH}/os/Packages/centos-gpg-keys-8-2.el8.noarch.rpm ; fi && \ | |||
| dnf -y install \ | |||
| https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm \ | |||
| https://rpm.manageiq.org/release/18-radjabov/el8/noarch/manageiq-release-18.0-1.el8.noarch.rpm && \ | |||
| https://rpm.manageiq.org/release/17-quinteros/el8/noarch/manageiq-release-17.0-1.el8.noarch.rpm && \ | |||
There was a problem hiding this comment.
I wasn't sure if I was also supposed to bump the manageiq-release to 17.1.0, or leave it at 17.0 since it's just a repo definition?
There was a problem hiding this comment.
No changes to the RPM repo, so I don't see any reason to bump the version there.
bdunne
approved these changes
Oct 30, 2023
Fryguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and bump to 17.1.0 (includes a cherry-pick of #423)