Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build rpms using ruby 3.3 #517

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Build rpms using ruby 3.3 #517

merged 1 commit into from
Nov 5, 2024

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Oct 24, 2024

This uses ruby 3.3 on appliances

@kbrock kbrock added enhancement New feature or request dependencies labels Oct 24, 2024
@kbrock kbrock changed the title Build rpms using ruby 3.3 [WIP] Build rpms using ruby 3.3 Oct 24, 2024
@kbrock kbrock added the wip label Oct 24, 2024
@kbrock
Copy link
Member Author

kbrock commented Oct 24, 2024 •
edited
Loading

WIP: this is working for me and I'm able to build rpms locally.

Have not installed on an appliance yet. Have not upgraded an appliance yet.

Just put in WIP to have discussions first

bdunne
bdunne reviewed Oct 28, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated
@@ -13,6 +13,7 @@ jobs:
matrix:
ruby-version:
- '3.1'
- '3.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 3.3, right?

@kbrock
Copy link
Member Author

kbrock commented Oct 31, 2024

un-WIP: These builds are working for me.
I'm ready to push forward with 3.3

@kbrock kbrock removed the wip label Oct 31, 2024
@kbrock kbrock changed the title [WIP] Build rpms using ruby 3.3 Build rpms using ruby 3.3 Oct 31, 2024
@bdunne bdunne merged commit e9c1776 into ManageIQ:master Nov 5, 2024
4 checks passed
@bdunne bdunne self-assigned this Nov 5, 2024
@bdunne bdunne added enhancement New feature or request and removed enhancement New feature or request labels Nov 5, 2024
@bdunne bdunne mentioned this pull request Nov 5, 2024
Merged
78 tasks
@kbrock kbrock deleted the ruby3.3 branch November 5, 2024 23:12
@Fryguy
Copy link
Member

Fryguy commented Nov 14, 2024

Backported to radjabov in commit dbe5107.

commit dbe51070f5525ce2eeb2e4928a54d2ae362f4be0
Author: Brandon Dunne <[email protected]>
Date:   Tue Nov 5 17:19:16 2024 -0500

    Merge pull request #517 from kbrock/ruby3.3
    
    Build rpms using ruby 3.3
    
    (cherry picked from commit e9c177605d042248d4cbd813596cb21fcbca011b)

Fryguy pushed a commit that referenced this pull request Nov 14, 2024
@bdunne @Fryguy
Merge pull request #517 from kbrock/ruby3.3
dbe5107 
Build rpms using ruby 3.3

(cherry picked from commit e9c1776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne left review comments

Assignees

@bdunne bdunne

Labels
dependencies enhancement New feature or request radjabov/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbrock @Fryguy @bdunne