Move paramiko into Dockerfile. #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
requested changes
Nov 22, 2024
Dockerfile
Outdated
| @@ -57,6 +57,7 @@ RUN ARCH=$(uname -m) && \ | |||
| python3-pip \ | |||
| python3-virtualenv \ | |||
| rpm-build && \ | |||
| python3-paramiko && \ | |||
There was a problem hiding this comment.
This a) needs to go up alphabetically and then b) should not have &&
|
update:
|
Fryguy
reviewed
Nov 25, 2024
| @@ -55,6 +55,7 @@ RUN ARCH=$(uname -m) && \ | |||
| openssl-devel \ | |||
| python3-devel \ | |||
| python3-pip \ | |||
| python3-paramiko \ | |||
Before ====== Installs python paramiko package via rpm Also installs paramiko python pip package. After ===== Ensure paramiko is available in the environment that builds the virtual env. virtual env building process will detect the package is available and and not try and install the paramiko pip package. So we end up with only 1 paramiko package installed. This will ensure we do not install the paramiko python pip package into the venv. History ======= This issue was introduced in - ManageIQ#509 - 3540110
|
update:
|
Fryguy
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Installs python paramiko package via rpm
Also installs paramiko python pip package.
After
Ensure paramiko is available in the environment that builds the virtual env. virtual env building process will detect the package is available and and not try and install the paramiko pip package. So we end up with only 1 paramiko package installed. This will ensure we do not install the paramiko python pip package into the venv.
History
This issue was introduced in