-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency psych to v5 #528
Conversation
85878c9
to
d3355e2
Compare
d3355e2
to
7cf3f94
Compare
7cf3f94
to
20fc08b
Compare
@@ -8,7 +8,7 @@ gem 'droplet_kit', "~>3.7", :require => false | |||
gem 'manageiq-style' | |||
gem 'more_core_extensions' | |||
gem 'optimist' | |||
gem 'psych', "<4" | |||
gem 'psych', "<5.2.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdunne I see this locally when I try to build master locally:
Fetching actionpack 8.0.1
Installing actionpack 8.0.1
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
current directory: /root/.local/share/gem/ruby/gems/psych-5.2.3/ext/psych
/usr/bin/ruby -I/usr/share/rubygems extconf.rb
checking for pkg-config for yaml-0.1... not found
checking for yaml.h... no
yaml.h not found
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers. Check the mkmf.log file for more details. You may
need configuration options.
Provided configuration options:
--with-opt-dir
--without-opt-dir
--with-opt-include=${opt-dir}/include
--without-opt-include
--with-opt-lib=${opt-dir}/lib64
--without-opt-lib
--with-make-prog
--without-make-prog
--srcdir=.
--curdir
--ruby=/usr/bin/$(RUBY_BASE_NAME)
--with-libyaml-source-dir
--without-libyaml-source-dir
--with-yaml-0.1-dir
--without-yaml-0.1-dir
--with-yaml-0.1-include=${yaml-0.1-dir}/include
--without-yaml-0.1-include
--with-yaml-0.1-lib=${yaml-0.1-dir}/lib64
--without-yaml-0.1-lib
--with-yaml-0.1-config
--without-yaml-0.1-config
--with-pkg-config
--without-pkg-config
--with-libyaml-dir
--without-libyaml-dir
--with-libyaml-include=${libyaml-dir}/include
--without-libyaml-include
--with-libyaml-lib=${libyaml-dir}/lib64
--without-libyaml-lib
To see why this extension failed to compile, please check the mkmf.log which can
be found here:
/root/.local/share/gem/ruby/extensions/x86_64-linux/3.3.0/psych-5.2.3/mkmf.log
extconf failed, exit code 1
Gem files will remain installed in /root/.local/share/gem/ruby/gems/psych-5.2.3
for inspection.
Results logged to
/root/.local/share/gem/ruby/extensions/x86_64-linux/3.3.0/psych-5.2.3/gem_make.out
/usr/share/rubygems/rubygems/ext/builder.rb:125:in `run'
/usr/share/rubygems/rubygems/ext/ext_conf_builder.rb:28:in `build'
/usr/share/rubygems/rubygems/ext/builder.rb:193:in `build_extension'
/usr/share/rubygems/rubygems/ext/builder.rb:227:in `block in build_extensions'
/usr/share/rubygems/rubygems/ext/builder.rb:224:in `each'
/usr/share/rubygems/rubygems/ext/builder.rb:224:in `build_extensions'
/usr/share/rubygems/rubygems/installer.rb:855:in `build_extensions'
/usr/local/share/gems/gems/bundler-2.6.5/lib/bundler/rubygems_gem_installer.rb:111:in
`build_extensions'
/usr/local/share/gems/gems/bundler-2.6.5/lib/bundler/rubygems_gem_installer.rb:30:in
`install'
/usr/local/share/gems/gems/bundler-2.6.5/lib/bundler/source/rubygems.rb:220:in
`install'
/usr/local/share/gems/gems/bundler-2.6.5/lib/bundler/installer/gem_installer.rb:55:in
`install'
/usr/local/share/gems/gems/bundler-2.6.5/lib/bundler/installer/gem_installer.rb:17:in
`install_from_spec'
/usr/local/share/gems/gems/bundler-2.6.5/lib/bundler/installer/parallel_installer.rb:133:in
`do_install'
/usr/local/share/gems/gems/bundler-2.6.5/lib/bundler/installer/parallel_installer.rb:124:in
`block in worker_pool'
/usr/local/share/gems/gems/bundler-2.6.5/lib/bundler/worker.rb:62:in
`apply_func'
/usr/local/share/gems/gems/bundler-2.6.5/lib/bundler/worker.rb:57:in `block in
process_queue'
<internal:kernel>:187:in `loop'
/usr/local/share/gems/gems/bundler-2.6.5/lib/bundler/worker.rb:54:in
`process_queue'
/usr/local/share/gems/gems/bundler-2.6.5/lib/bundler/worker.rb:90:in `block (2
levels) in create_threads'
An error occurred while installing psych (5.2.3), and Bundler cannot continue.
In Gemfile:
rspec-rails was resolved to 7.1.1, which depends on
railties was resolved to 8.0.1, which depends on
irb was resolved to 1.15.1, which depends on
rdoc was resolved to 6.12.0, which depends on
psych
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverting this change locally makes it get much further
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it broke the build too:
https://github.com/ManageIQ/manageiq-rpm_build/actions/runs/13447148636/job/37575122953
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if it's https://www.github.com/ruby/psych/pull/541... looks like we also need pkg-config
and libyaml-dev
, see also: https://www.github.com/rails/rails-dev-box/pull/202
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkg-config should be in development tools so it might just be libyaml-devel
Note, build_rpms github action was still passing so why do we even need psych here? Should something be failing the build or can we delete psych as a dependency? This fixes the error below if we really need psych 5+: ``` Installing psych 5.2.3 with native extensions Gem::Ext::BuildError: ERROR: Failed to build gem native extension. current directory: /root/.local/share/gem/ruby/gems/psych-5.2.3/ext/psych /usr/bin/ruby -I/usr/share/rubygems extconf.rb checking for pkg-config for yaml-0.1... not found checking for yaml.h... no yaml.h not found *** extconf.rb failed *** Could not create Makefile due to some reason, probably lack of necessary libraries and/or headers. Check the mkmf.log file for more details. You may need configuration options. ```
https://github.com/ManageIQ/manageiq-rpm_build/blob/master/.github/workflows/build_rpms.yaml, was quietly printing the error below without failing the build. See: https://www.github.com/ruby/psych/pull/541 and related solution in https://www.github.com/rails/rails-dev-box/pull/202 Note, build_rpms github action was still passing so why do we even need psych here? Should something be failing the build or can we delete psych as a dependency? This fixes the error below if we really need psych 5+: ``` Installing psych 5.2.3 with native extensions Gem::Ext::BuildError: ERROR: Failed to build gem native extension. current directory: /root/.local/share/gem/ruby/gems/psych-5.2.3/ext/psych /usr/bin/ruby -I/usr/share/rubygems extconf.rb checking for pkg-config for yaml-0.1... not found checking for yaml.h... no yaml.h not found *** extconf.rb failed *** Could not create Makefile due to some reason, probably lack of necessary libraries and/or headers. Check the mkmf.log file for more details. You may need configuration options. ```
PR ManageIQ#528 upgraded psych to allow version 5 and https://github.com/ManageIQ/manageiq-rpm_build/blob/master/.github/workflows/build_rpms.yaml, was quietly printing the error below without failing the build. See: https://www.github.com/ruby/psych/pull/541 and related solution in https://www.github.com/rails/rails-dev-box/pull/202 Note, build_rpms github action was still passing so why do we even need psych here? Should something be failing the build or can we delete psych as a dependency? This fixes the error below if we really need psych 5+: ``` Installing psych 5.2.3 with native extensions Gem::Ext::BuildError: ERROR: Failed to build gem native extension. current directory: /root/.local/share/gem/ruby/gems/psych-5.2.3/ext/psych /usr/bin/ruby -I/usr/share/rubygems extconf.rb checking for pkg-config for yaml-0.1... not found checking for yaml.h... no yaml.h not found *** extconf.rb failed *** Could not create Makefile due to some reason, probably lack of necessary libraries and/or headers. Check the mkmf.log file for more details. You may need configuration options. ```
Add libyaml-devel for psych 5+ broken in #528
Previously, when bundle failed following ManageIQ#528, the script continued and finished the build. It's unclear if the psych 5 error mattered because our build still finished but we probably want to fail builds and fix issues if the entrypoint script encounters non-zero exit codes. Pull ManageIQ#546 fixed the psych 5 issue and describes the issue of the silent error.
This PR contains the following updates:
"<4"
->"<5.2.4"
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.