Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VimStrings from MiqQueue #706

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Sep 21, 2023

Events used to have vmware specific objects in the queue. These leaked through for a customer and it blew up.

This has not been in the queue for a number of years, but if someone delays upgrading and then doesn't empty the queue before upgrading... this will happen.

The solution is to remove entries

See also

Events used to have vmware specific objects in the queue.
These leaked through for a customer and it blew up.

This has not been in the queue for a number of years, but if someone delays
upgrading and then doesn't empty the queue before upgrading... this will happen.

The solution is to remove entries
@kbrock kbrock force-pushed the vim_string_migrations branch from ddcc0d0 to 236226a Compare September 27, 2023 18:44
@miq-bot
Copy link
Member

miq-bot commented Sep 27, 2023

Checked commit kbrock@236226a with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
7 files checked, 0 offenses detected
Everything looks fine. 🍰

@kbrock
Copy link
Member Author

kbrock commented Sep 27, 2023

update:

  • fixed rubocops
  • fixed method rename that wasn't fully done.
  • refactored other migrations to use this common function

Punted:

  • VimString replace that followed a different pattern ems_ref_obj - think is not applicable.
  • VimString replace of a binary column. binary_blobs follows the same pattern, but would add 25% more code from conditional logic. your call

@agrare agrare merged commit 26c9501 into ManageIQ:master Sep 28, 2023
@kbrock kbrock deleted the vim_string_migrations branch September 28, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants