Add payload validity attributes to configuration_scripts #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add columns to store if the payload of a configuration_script is valid or not, and if not what the error is to help the user fix their scripts.
2 tasks
Fryguy
reviewed
Nov 8, 2023
| @@ -0,0 +1,6 @@ | |||
| class AddValidToConfigurationScripts < ActiveRecord::Migration[6.1] | |||
| def change | |||
| add_column :configuration_scripts, :payload_valid, :boolean | |||
There was a problem hiding this comment.
Should we set a default of true (or in Ruby use default_value_for)? Reason I'm asking is that ansible playbooks will be seen as "nil" valid, which is falsey in Ruby, so .payload_valid? will return false.
|
Checked commits agrare/manageiq-schema@def35ca~...bf65b56 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
Moving this to yes? until the parent PR is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add columns to store if the payload of a configuration_script is valid or not, and if not what the error is to help the user fix their scripts.