Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default from config_scripts payload_valid #712

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agrare
Copy link
Member

@agrare agrare commented Nov 14, 2023

Only set payload_valid if it was checked otherwise leave it as nil

ManageIQ/manageiq-providers-workflows#59 (comment)

Only set payload_valid if it was checked otherwise leave it as `nil`
@agrare agrare force-pushed the remove_default_from_configuration_scripts_payload_valid branch from 5b06f6c to 36c0807 Compare November 14, 2023 17:55
@miq-bot
Copy link
Member

miq-bot commented Nov 14, 2023

Checked commit agrare@36c0807 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 2 offenses detected

db/migrate/20231114173829_remove_default_from_configuration_scripts_payload_valid.rb

@agrare
Copy link
Member Author

agrare commented Dec 4, 2023

ping @Fryguy

@miq-bot
Copy link
Member

miq-bot commented Mar 11, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@kbrock
Copy link
Member

kbrock commented Mar 11, 2024

ping. Is this ready?

@kbrock
Copy link
Member

kbrock commented Apr 5, 2024

@Fryguy Is there a timeframe that is best to merge these schema PRs?

@Fryguy
Copy link
Member

Fryguy commented Apr 5, 2024

This one fell to the backburner, but I originally had concerns/thoughts around how to handle providers that don't support this column, and thus the value would be nil, and what that means (i.e. since nil is falsey, are they therefore invalid by default?)

@miq-bot
Copy link
Member

miq-bot commented Jul 8, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@agrare
Copy link
Member Author

agrare commented Sep 4, 2024

@Fryguy how about we rename this payload_invalid so that the "unset" case isn't that the content is bad.

@miq-bot
Copy link
Member

miq-bot commented Dec 9, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants