-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default from config_scripts payload_valid #712
base: master
Are you sure you want to change the base?
Remove default from config_scripts payload_valid #712
Conversation
Only set payload_valid if it was checked otherwise leave it as `nil`
5b06f6c
to
36c0807
Compare
Checked commit agrare@36c0807 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint db/migrate/20231114173829_remove_default_from_configuration_scripts_payload_valid.rb
|
ping @Fryguy |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
ping. Is this ready? |
@Fryguy Is there a timeframe that is best to merge these schema PRs? |
This one fell to the backburner, but I originally had concerns/thoughts around how to handle providers that don't support this column, and thus the value would be nil, and what that means (i.e. since nil is falsey, are they therefore invalid by default?) |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
@Fryguy how about we rename this |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
Only set payload_valid if it was checked otherwise leave it as
nil
ManageIQ/manageiq-providers-workflows#59 (comment)