Customized 'volumes' tab for IBM PVS in '_prov_dialog.html.haml'

[iv10]

• IBM Power Virtual Server related change
• in case of IBM PVS provisioning form the
  following fields are shown: name, size, diskType, shareable
• types: text, text, text, checkbox (respectively)

Depends:

• Add 'keys_for_volumes' method defining default fields on vol. tab  manageiq#20618

[iv10]

The change is small but the changed code is shared at least with the OpenStack provider.

[iv1111]

corresponding back-end support is in this PR: ManageIQ/manageiq-providers-ibm_cloud#47

[iv1111]

Does this require a check from Lucy? (since it touches common code)

[agrare]

Thanks for helping us out on this @iv10 I know so much of the rest of this file is done the way you had it so that's a natural way to do this.

I created #7353 so we don't forget to come back and refactor this so the existing code is up to pluggability standards

[iv1111]

Thanks for helping us out on this @iv10 I know so much of the rest of this file is done the way you had it so that's a natural way to do this.

I created #7353 so we don't forget to come back and refactor this so the existing code is up to pluggability standards

Sure, np. 👍 I'll do the changes according to your suggestions.

[skateman]

@iv1111 can you please link the related PRs to core/provider here? Ideally up in the description...

[miq-bot]

Checked commits https://github.com/iv10/manageiq-ui-classic/compare/f0d6751d7bc4f0fa345f2f64ae67669eeaa1dc15~...dc96bf6f9428da47d9af03565abc115d8f81d483 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby26, which recognizes
warning: 2.6.6-compliant syntax, but you are running 2.6.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

[iv10]

The dependency in the MIQ base has been merged now, can we merge the current one then, i've removed [WIP].

[skateman]