a11y: Allow the user to exit the menu when unfocusing or ESC #7406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
skateman
changed the title
|
i think second solution seems better, when shift+tab focus shifted to first level menu from second level, then second menu should be collapsible. |
skateman
force-pushed
the
a11y-menu-escape-unfocus
branch
from
5e4df63 to
efbe188
Compare
skateman
force-pushed
the
a11y-menu-escape-unfocus
branch
from
efbe188 to
cd4b3c5
Compare
skateman
changed the title
skateman
force-pushed
the
a11y-menu-escape-unfocus
branch
from
cd4b3c5 to
25635f0
Compare
|
Checked commit skateman@25635f0 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
h-kataria
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set an
onKeyDownevent on both menu levels, if the ESC key is pressed, the second level of the menu gets collapsed. I also made the overlay focusable, so if the user goes through the menu, it gets collapsed before the user can enter the main content area.With the current implementation there's one catch though: if the user expands the second level and starts moving on the menu items with the keyboard backwards (SHIFT+TAB), it can go around and can get to the main content area without collapsing. I have a few ideas about how this could be solved:
window.onblurand collapse the menu (alt+tab would also collapse the menu)Parent issue #7358