Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsoDatastore to Storage support #8548

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

nasark
Copy link
Member

@nasark nasark commented Nov 28, 2022

  • IsoDatastore will be modelled under Storage with STI :type => ManageIQ::Providers::Ovirt::InfraManager::IsoDatastore, therefore these changes aim to keep the iso datastore views in tact alongside the modelling change
  • create and edit operations for iso datastores can be removed as this will be handled by provider refreshes moving forward
  • see Subclass IsoDatastore and transfer from core manageiq-providers-ovirt#621 for more details

Screen Shot 2022-12-06 at 10 19 47 AM

Screen Shot 2022-12-06 at 10 22 10 AM

Screen Shot 2022-12-06 at 10 19 20 AM

Depends on:

TODO:

  • Fix specs

@miq-bot assign @jeffibm
@miq-bot add_reviewer @agrare
@miq-bot add_labels enhancement, technical debt

@nasark nasark requested a review from a team as a code owner November 28, 2022 14:24
@miq-bot miq-bot requested a review from agrare November 28, 2022 14:26
@nasark nasark force-pushed the iso_datastore_to_storage_support branch 3 times, most recently from 29912f7 to 9fdddb3 Compare December 6, 2022 15:18
@nasark nasark changed the title [WIP] IsoDatastore to Storage support IsoDatastore to Storage support Dec 6, 2022
@miq-bot miq-bot removed the wip label Dec 6, 2022
@nasark nasark force-pushed the iso_datastore_to_storage_support branch from 9fdddb3 to 2358dd9 Compare December 12, 2022 21:23
@miq-bot
Copy link
Member

miq-bot commented Dec 12, 2022

Checked commit nasark@2358dd9 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
6 files checked, 2 offenses detected

app/helpers/pxe_helper/textual_summary.rb

@nasark
Copy link
Member Author

nasark commented Dec 13, 2022

Cross-repo tests are green (manageiq-api failures are unrelated)

@agrare agrare merged commit 4566cde into ManageIQ:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants