Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yarn to 4.0.0.rc51 since it's works on s390x #8924

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

@Fryguy Fryguy requested a review from a team as a code owner September 18, 2023 20:47
@miq-bot
Copy link
Member

miq-bot commented Sep 18, 2023

Some comments on commit Fryguy@f5087ca

.yarn/releases/yarn-4.0.0-rc.51.cjs

  • ⚠️ - 12 - Detected pp. Remove all debugging statements.
  • ⚠️ - 132 - Detected pp. Remove all debugging statements.
  • ⚠️ - 134 - Detected pp. Remove all debugging statements.
  • ⚠️ - 288 - Detected pp. Remove all debugging statements.
  • ⚠️ - 291 - Detected pp. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Sep 18, 2023

Checked commit Fryguy@f5087ca with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@bdunne bdunne merged commit 2b5f6d2 into ManageIQ:master Sep 18, 2023
@bdunne bdunne self-assigned this Sep 18, 2023
@Fryguy Fryguy deleted the yarn4 branch September 19, 2023 13:29
@Fryguy
Copy link
Member Author

Fryguy commented Sep 19, 2023

I forgot to remove the yarn1 hack - Follow up PR: #8925

@Fryguy
Copy link
Member Author

Fryguy commented Sep 25, 2023

Backported to quinteros in commit 03d22a2.

commit 03d22a265cc4d273243a3f0ef3eab90142192931
Author: Brandon Dunne <[email protected]>
Date:   Mon Sep 18 17:10:43 2023 -0400

    Merge pull request #8924 from Fryguy/yarn4
    
    Update yarn to 4.0.0.rc51 since it's works on s390x
    
    (cherry picked from commit 2b5f6d20695084721a33775e779b1886e78be24a)

Fryguy pushed a commit that referenced this pull request Sep 25, 2023
Update yarn to 4.0.0.rc51 since it's works on s390x

(cherry picked from commit 2b5f6d2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants