Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Convert Service Reconfigure Form Page to React #8951

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

DavidResende0
Copy link
Member

@DavidResende0 DavidResende0 commented Nov 1, 2023

Depends On: #8953, #8890 and #8911

@miq-bot
Copy link
Member

miq-bot commented Nov 2, 2023

Checked commits DavidResende0/manageiq-ui-classic@2859537~...8ac0b50 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
13 files checked, 11 offenses detected

app/views/miq_request/_request_dialog_details.html.haml

  • ⚠️ - Line 31 - Style/ClassEqualityComparison: Use instance_of?(Integer) instead of comparing classes.
  • ⚠️ - Line 32 - Style/HashEachMethods: Use each_value instead of values.each.
  • ⚠️ - Line 34 - Style/SoleNestedConditional: Consider merging nested conditions into outer if conditions.
  • ⚠️ - Line 38 - Style/HashEachMethods: Use each_value instead of values.each.
  • ⚠️ - Line 40 - Style/SoleNestedConditional: Consider merging nested conditions into outer if conditions.
  • ⚠️ - Line 45 - Style/HashEachMethods: Use each_value instead of values.each.
  • ⚠️ - Line 47 - Style/SoleNestedConditional: Consider merging nested conditions into outer if conditions.

app/views/service/service_reconfigure.html.haml

  • ⚠️ - Line 1 - Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
  • ⚠️ - Line 1 - Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
  • ⚠️ - Line 2 - Layout/TrailingEmptyLines: Final newline missing.

app/views/shared/dialogs/_dialog_user.html.haml

  • ⚠️ - Line 2 - Avoid using instance variables in partials views

@DavidResende0
Copy link
Member Author

Separated the fixes from the form conversion and made a new pr here: #8953

@DavidResende0 DavidResende0 changed the title [WIP] Fix Broken Service Reconfigure Form Page and Update to React [WIP] Convert Service Reconfigure Form Page to React Nov 2, 2023
@DavidResende0 DavidResende0 removed the bug label Nov 2, 2023
@DavidResende0 DavidResende0 mentioned this pull request Nov 7, 2023
10 tasks
@miq-bot
Copy link
Member

miq-bot commented Nov 14, 2023

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Feb 19, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@jeffibm
Copy link
Member

jeffibm commented Mar 13, 2024

hey @DavidResende0 , could you please rebase this PR?
Also when you find time, could you please update the ToDo List?
Thanks

@miq-bot
Copy link
Member

miq-bot commented Jun 17, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented Sep 23, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants