Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Settings replication form #9016

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DavidResende0
Copy link
Member

@DavidResende0 DavidResende0 commented Jan 10, 2024

Preview:
image
image
image

@jeffibm
Copy link
Member

jeffibm commented Mar 7, 2024

hey @DavidResende0 , could you please add a few screenshots in here.

@miq-bot
Copy link
Member

miq-bot commented Mar 7, 2024

Checked commits DavidResende0/manageiq-ui-classic@213955a~...3cd6c6c with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 3 offenses detected

app/views/ops/_settings_replication_tab.html.haml

  • 💣 💥 🔥 🚒 - Line 47 - Do not repeat id "#host" on the page
  • 💣 💥 🔥 🚒 - Line 54 - Do not repeat id "#host" on the page
  • ⚠️ - Line 2 - id attribute must be in lisp-case

@jeffibm
Copy link
Member

jeffibm commented Mar 9, 2024

A small suggestion that we can look into later -

As you can see in the screenshots in PR description, when you add/edit a subscription, the entire form gets replaced. We have a similar logic in the #8710.

One reason for taking this approach was that we would get an error message in the browser console saying you cannot include a Form within a Form.

If possible we can proceed with a similar approach as we do for input parameters here - #9047 (comment)

We can place the modal-box outside the actual form and handle the data logic within the parent component.

@jeffibm
Copy link
Member

jeffibm commented Mar 13, 2024

Hey @DavidResende0 ,
Could you please update the ToDo List when you find time?
Thanks

@miq-bot miq-bot added the stale label Jun 17, 2024
@miq-bot
Copy link
Member

miq-bot commented Jun 17, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented Sep 23, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants