-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering and selecting embedded methods used in the inline-methods form pages #9059
Conversation
b0a7cdf
to
ecffe86
Compare
Screen.Recording.2024-02-29.at.4.48.40.PM.mov |
3e9fecc
to
4906c56
Compare
4e40313
to
206a526
Compare
@@ -0,0 +1,55 @@ | |||
.inline-method-selector { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this file to the global css path
34ad4da
to
c32d67a
Compare
4b0692c
to
d52357d
Compare
Update as of May 7, 2025
Screen.Recording.2024-05-07.at.9.16.40.PM.mov |
8cce049
to
7a94e93
Compare
4f76227
to
d93c66e
Compare
d93c66e
to
45c61dc
Compare
Update as of May 18, 2025
Screen.Recording.2024-05-18.at.9.45.41.AM.mov |
e528d57
to
d00ae34
Compare
5759230
to
bf9b57c
Compare
This pr looks good, once the core pr is ready to be merged this can be merged with it. |
4cce505
to
6459d24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm making changes to the other side.
Think these should be good for you
6459d24
to
98671ab
Compare
Checked commit jeffbonson@98671ab with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint app/views/miq_ae_class/_embedded_methods.html.haml |
update:
|
Related PR - ManageIQ/manageiq#22921 (used for named scopes)
Last update in here - #9059 (comment)
AeInlineMethods
component to render the list and add method buttonmodal
to display the list.Selector
componentmiq_ae_class_controller
selector
componentGET: http://...miq_ae_class/ae_domains
GET: http://..../miq_ae_class/ae_methods