Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert ServiceTemplate.orderable? to supports?(:order) #9071

Closed
wants to merge 1 commit into from

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Feb 7, 2024

Moving ServiceTemplate over to pure supports mixin

This allows us to dropping ServiceTemplate#orderable? in ManageIQ/manageiq#22883

Trying to move this over to supports mixin
(dropping orderable?)
@kbrock kbrock requested a review from a team as a code owner February 7, 2024 23:44
@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2024

Checked commit kbrock@12917ee with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
5 files checked, 9 offenses detected

app/helpers/application_helper/button/orchestration_template_orderable.rb

app/helpers/application_helper/button/orchestration_template_view_in_catalog.rb

app/views/orchestration_stack/_stack_orchestration_template.html.haml

  • 💣 💥 🔥 🚒 - Line 1 - Do not repeat id "#form_div" on the page
  • 💣 💥 🔥 🚒 - Line 32 - Do not repeat id "#form_div" on the page
  • ⚠️ - Line 22 - Avoid using instance variables in partials views
  • ⚠️ - Line 24 - Avoid using instance variables in partials views
  • ⚠️ - Line 24 - Line is too long. [89/80]

@kbrock
Copy link
Member Author

kbrock commented Feb 9, 2024

For now, keeping orderable
ServiceTemplate and OrchestrationTemplate both implement the method (though one uses supports and the other uses an attribute in the model)

We may want to address in the future

@kbrock kbrock closed this Feb 9, 2024
@kbrock kbrock deleted the supports_array branch February 9, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants