Fix the settings ops schedule toolbar #9505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asirvadAbrahamVarghese
approved these changes
Jun 24, 2025
Fryguy
reviewed
Jun 24, 2025
|
I don't understand how |
Fryguy
reviewed
Jun 24, 2025
Fryguy
reviewed
Jun 24, 2025
GilbertCherrie
force-pushed
the
fix_ops_schedule_toolbar
branch
from
9a50365 to
f09376c
Compare
GilbertCherrie
force-pushed
the
fix_ops_schedule_toolbar
branch
from
f09376c to
691a738
Compare
|
@Fryguy I fixed the issues with the pr if you can review it again |
|
Checked commit GilbertCherrie@691a738 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.62.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was found by @asirvadAbrahamVarghese
Fix the settings ops toolbar to not display while in the schedule form, similar to the other forms on the ops page.
Before:
After:
Still has the configuration button outside of the form.
No configuration button inside of the form.
